Skip to content

CircleCI: update docker versions used in CI#2563

Merged
silvin-lubecki merged 1 commit into
docker:masterfrom
thaJeztah:bump_circleci_docker
Jun 11, 2020
Merged

CircleCI: update docker versions used in CI#2563
silvin-lubecki merged 1 commit into
docker:masterfrom
thaJeztah:bump_circleci_docker

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

CircleCI now has 19.03; https://circleci.com/docs/2.0/building-docker-images/#docker-version

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #2563 into master will increase coverage by 1.22%.
The diff coverage is 73.40%.

@@            Coverage Diff             @@
##           master    #2563      +/-   ##
==========================================
+ Coverage   56.78%   58.01%   +1.22%     
==========================================
  Files         311      295      -16     
  Lines       21832    21135     -697     
==========================================
- Hits        12398    12261     -137     
+ Misses       8519     7974     -545     
+ Partials      915      900      -15     

@thaJeztah

Copy link
Copy Markdown
Member Author

@silvin-lubecki @vdemeester PTAL

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@silvin-lubecki silvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki
silvin-lubecki merged commit 4f63781 into docker:master Jun 11, 2020
@thaJeztah
thaJeztah deleted the bump_circleci_docker branch June 11, 2020 13:21
@thaJeztah thaJeztah added this to the 20.03.0 milestone Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants